Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Close any open flyouts when changing view mode of the dashboard #6923

Merged
merged 1 commit into from
Jul 1, 2024
Merged

Close any open flyouts when changing view mode of the dashboard #6923

merged 1 commit into from
Jul 1, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

Description

Adds a mechanism to close an active "service" flyout and employs that in the Dashboard editing flow.

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions github-actions bot added distinguished-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jun 5, 2024
@AMoo-Miki AMoo-Miki added backport 2.x v2.15.0 and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels Jun 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 5, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.45%. Comparing base (b85e177) to head (517ec4b).

Files Patch % Lines
...board/public/application/utils/get_nav_actions.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #6923      +/-   ##
==========================================
- Coverage   67.45%   67.45%   -0.01%     
==========================================
  Files        3448     3448              
  Lines       67964    67970       +6     
  Branches    11057    11058       +1     
==========================================
+ Hits        45845    45849       +4     
- Misses      19446    19448       +2     
  Partials     2673     2673
Flag Coverage Δ
Linux_1 33.10% <28.57%> (-0.01%) ⬇️
Linux_2 55.06% <100.00%> (+<0.01%) ⬆️
Linux_3 45.25% <28.57%> (+0.01%) ⬆️
Linux_4 34.82% <28.57%> (-0.01%) ⬇️
Windows_1 33.12% <28.57%> (-0.01%) ⬇️
Windows_2 55.01% <100.00%> (+<0.01%) ⬆️
Windows_3 45.25% <28.57%> (-0.02%) ⬇️
Windows_4 34.82% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc approved these changes Jun 6, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AMoo-Miki can you add a test for this

ananzh
ananzh previously approved these changes Jun 6, 2024
View reviewed changes
ashwin-pc
ashwin-pc requested changes Jun 6, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding off accidentally merging it without a test

@ashwin-pc ashwin-pc added v2.16.0 and removed v2.15.0 labels Jun 6, 2024
@AMoo-Miki AMoo-Miki requested a review from LDrago27 as a code owner June 28, 2024 20:53
@AMoo-Miki AMoo-Miki requested a review from ashwin-pc June 28, 2024 20:53
ashwin-pc
ashwin-pc approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the tests :)

Nit: Lets add a readme here for these overlay's and other core API's so that they show up in the developer docs

@AMoo-Miki AMoo-Miki merged commit 6bbace1 into opensearch-project:main Jul 1, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 1, 2024
@github-actions
Close any open system flyout when changing view mode of the dashboard (…
b219905 
…#6923)

Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit 6bbace1)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 1, 2024
Merged
ananzh pushed a commit that referenced this pull request Jul 3, 2024
@opensearch-trigger-bot @github-actions
Close any open system flyout when changing view mode of the dashboard (…
ed6371f 
…#6923) (#7137)

(cherry picked from commit 6bbace1)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@ananzh ananzh ananzh left review comments

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

Assignees

@kavilla kavilla

@ashwin-pc ashwin-pc

@ananzh ananzh

Labels
backport 2.x distinguished-contributor v2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AMoo-Miki @ashwin-pc @abbyhu2000 @ananzh @kavilla